False positive implicit yield violation

[AlwxSin]

Bug report

What's wrong

With common function to split iterable by chunks WPS raises ImplicitYieldFromViolation

def chunks(value, chunk_size):
    """Yield successive n-sized chunks from l."""
    for index in range(0, len(value), chunk_size):
        yield value[index:index + chunk_size]

How is that should be

ImplicitYieldFromViolation should be raised only if no other operations with iterable item.

[sobolevn]

What about

yield from (
    value[index:index + chunk_size]
    for index in range(0, len(value), chunk_size)
)

?

[AlwxSin]

Less readable in my taste. But if no other choices I will use it. Thanks.

[sobolevn]

Thanks for raising this, I guess we need to update the violation docs about this case.

[AlwxSin]

@sobolevn there is still a bug.
Python does not support 'yield from' inside async functions

[sobolevn]

Yes, that's true.

[sobolevn]

This rule should be ignored for async functions.

Can you please add a check that if isinstance(get_context(node), ast.AsyncFunctionDef): return?

[AlwxSin]

Of course, I'll do it.