Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editorial control of image presence within Prismic #10865

Open
davidpmccormick opened this issue May 13, 2024 · 0 comments
Open

Allow editorial control of image presence within Prismic #10865

davidpmccormick opened this issue May 13, 2024 · 0 comments
Labels
epic: slice machine prismic anything to do with our use of Prismic

Comments

@davidpmccormick
Copy link
Contributor

davidpmccormick commented May 13, 2024

When migrating Prismic content we removed the standalone and supporting labels since they would stop working in Slice Machine land. We also decided not to re-implement them using an extra field on the type (as we did for e.g. quotes) because the way they were implemented meant there was no good way of knowing if they were going to have the desired effect on the image when it was rendered on the frontend (based on the image aspect-ratio and, crucially, the user's browser).

The photography editors still have a desire to give different images varying degrees of presence within the body of a page so we should find a way to accommodate this.

It might be a case of treating landscape and portrait images differently so that they proportionally take up similar amounts of space on a page. Potentially with an option to limit any image to a maximum number of grid columns.

Propsal from photography:
ImageSize Proposal.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: slice machine prismic anything to do with our use of Prismic
Projects
Status: Backlog
Development

No branches or pull requests

1 participant