Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run type checks as a git hook? github action? #10844

Open
rcantin-w opened this issue May 2, 2024 · 0 comments
Open

Run type checks as a git hook? github action? #10844

rcantin-w opened this issue May 2, 2024 · 0 comments

Comments

@rcantin-w
Copy link
Contributor

We should run type checks at some point (PRs? builds?) to ensure we're in-line at all times. This came up because our mocks tend to get very out of date; an example is Prismic's Image type where they added two new required fields. Most mocks started showing errors, but as they're never interacted with, they're not getting updated.

We should add a type check, with a PR that fixes all flagged issues. Then, if/when it happens again, it has to be addressed right away and we're less in danger of falling behind.

Github action? https://github.com/marketplace/actions/typescript-compiler
Git hook? https://github.com/guardian/pressreader/blob/main/scripts/setup#L9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant