Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAXException with Icons #320

Closed
GraxCode opened this issue Apr 20, 2022 · 4 comments
Closed

SAXException with Icons #320

GraxCode opened this issue Apr 20, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@GraxCode
Copy link

GraxCode commented Apr 20, 2022

Describe the bug
I got this exception randomly while rendering a JTree. It only happened once, and I don't know how to reproduce it. Maybe has to do with missing synchronization.

WARNUNG: Could not load SVG 
org.xml.sax.SAXException: FWK005 parse may not be called while parsing.
	at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1266)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:635)
	at com.github.weisj.jsvg.parser.SVGLoader.load(SVGLoader.java:136)
	at com.github.weisj.jsvg.parser.SVGLoader.load(SVGLoader.java:116)
	at com.github.weisj.darklaf.properties.icons.DarkSVGIcon$SVGDocumentHolder.ensureLoaded(DarkSVGIcon.java:335)
	at com.github.weisj.darklaf.properties.icons.DarkSVGIcon$SVGDocumentHolder.svgDocument(DarkSVGIcon.java:347)
	at com.github.weisj.darklaf.properties.icons.DarkSVGIcon$SVGDocumentHolder.access$300(DarkSVGIcon.java:315)
	at com.github.weisj.darklaf.properties.icons.DarkSVGIcon.getSVGDocument(DarkSVGIcon.java:285)
	at com.github.weisj.darklaf.properties.icons.DarkSVGIcon.ensureSizeLoaded(DarkSVGIcon.java:254)
	at com.github.weisj.darklaf.properties.icons.DarkSVGIcon.getIconWidth(DarkSVGIcon.java:238)
	at java.desktop/javax.swing.JLabel.setIcon(JLabel.java:396)

To Reproduce
I don't know how to.

Additional Information:

  • Darklaf Version: 3.0.0
@GraxCode GraxCode added the bug Something isn't working label Apr 20, 2022
@weisJ
Copy link
Owner

weisJ commented Apr 20, 2022

Is there more to this stacktrace? Theoretically this shouldn’t be able to happen as long as all operations are confined to the swing thread (nonetheless I’ll try to make this more robust)

@weisJ
Copy link
Owner

weisJ commented Apr 23, 2022

Should be fixed with the latest snapshot. I'll release a fix version if this works for you :)

@GraxCode
Copy link
Author

It's not that urgent. Release it with the next version ;)

@weisJ
Copy link
Owner

weisJ commented Aug 1, 2022

Version 3.0.1 has been released and should fix it.

@weisJ weisJ closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants