Skip to content

ESLint in VS code broken after 1.6.1 upgrade #180

Closed
@SirSKillz

Description

@SirSKillz

Current Behavior

Inside of VS code, eslint does not function if you extend the dts-cli as suggested in the README due to @typescript-eslint/eslint-plugin and @typescript-eslint/parser being removed from dependencies and moved into dev dependencies in b90cc74

Expected behavior

After creating the .eslintrc.js file as explained in the README, ESLint should function correctly inside of VS code. While it is common and an easy workaround to install these dependencies inside of our own projects, it should still function without doing so.

Suggested solution(s)

Add both @typescript-eslint/eslint-plugin and @typescript-eslint/parser back to the dependencies of this project

Your environment

System:
    OS: Windows 10 10.0.19044
    CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
    Memory: 20.26 GB / 31.91 GB
  Binaries:
    Node: 16.17.1 - C:\Program Files\nodejs\node.EXE
    npm: 8.15.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 108.0.5359.125
    Edge: Spartan (44.19041.1266.0), Chromium (108.0.1462.46)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    dts-cli: ^1.6.2 => 1.6.2
    typescript: ^4.9.4 => 4.9.4

Activity

aladdin-add

aladdin-add commented on Dec 23, 2022

@aladdin-add

ah, my bad! will release a patch soon, thanks for the report! ❤️

added a commit that references this issue on Dec 23, 2022
636c5e7
aladdin-add

aladdin-add commented on Dec 23, 2022

@aladdin-add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @aladdin-add@SirSKillz

        Issue actions

          ESLint in VS code broken after 1.6.1 upgrade · Issue #180 · weiran-zsd/dts-cli