Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite contactFindAll() #1251

Closed
lijiarui opened this issue May 30, 2018 · 3 comments
Closed

rewrite contactFindAll() #1251

lijiarui opened this issue May 30, 2018 · 3 comments
Assignees

Comments

@lijiarui
Copy link
Member

lijiarui commented May 30, 2018

#1249

should complete the contactFindAll()

@lijiarui lijiarui changed the title contactFindAll and roomFindAll rewrite contactFindAll() May 30, 2018
@huan
Copy link
Member

huan commented May 31, 2018

Good news: there will be not necessary to implement contactFindAll() for a puppet for now.

You need to implement contactList() instead, should return all contactId as a string[].

Know more from #1255

@huan huan assigned lijiarui and unassigned huan May 31, 2018
@huan
Copy link
Member

huan commented Jun 8, 2018

Done.

Please check and close this issue if there's no problem.

@lijiarui
Copy link
Member Author

all is ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants