Return server from server.listen for method chaining to work #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
DiegoRBaquero
approved these changes
Jun 25, 2019
|
I had fixed returning server, but I prefer your version :). Thank you! |
|
🎉 Congrats on getting your first pull request landed! |
|
0.107.15 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This should fix webtorrent/webtorrent-cli#101 and webtorrent/webtorrent-cli#100. There was some breaking change in #1547. We used to return server for method chaining, to do stuff like
server.listen(...).on('error...'), and it broke. This PR fixes everything back to normal.