From 03291fa032ae6fac35e047ff39a77a2e00c9cf44 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tadeusz=20W=C3=B3jcik?= Date: Fri, 11 Oct 2019 08:28:14 +0200 Subject: [PATCH 1/3] [minor] allow overriding default duplex stream options for createWebSocketStream --- lib/stream.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/stream.js b/lib/stream.js index adfcf3193..0e91e81fe 100644 --- a/lib/stream.js +++ b/lib/stream.js @@ -63,12 +63,12 @@ function createWebSocketStream(ws, options) { } const duplex = new Duplex({ - ...options, autoDestroy: false, emitClose: false, objectMode: false, readableObjectMode: false, - writableObjectMode: false + writableObjectMode: false, + ...options }); ws.on('message', function message(msg) { From 0bf43b9e5095f7230cec4118160494945278a5f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tadeusz=20W=C3=B3jcik?= Date: Fri, 11 Oct 2019 15:45:17 +0200 Subject: [PATCH 2/3] remove objectMode, writableObjectMode, readableObjectMode explicit options which by default are set to false --- lib/stream.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/stream.js b/lib/stream.js index 0e91e81fe..fc617ab16 100644 --- a/lib/stream.js +++ b/lib/stream.js @@ -63,12 +63,9 @@ function createWebSocketStream(ws, options) { } const duplex = new Duplex({ + ...options, autoDestroy: false, - emitClose: false, - objectMode: false, - readableObjectMode: false, - writableObjectMode: false, - ...options + emitClose: false }); ws.on('message', function message(msg) { From aa3cc3e6fdbc342d60e710bb0a47f39c71e2b334 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Mon, 14 Oct 2019 16:11:24 +0200 Subject: [PATCH 3/3] Set the objectMode and writableObjectMode option to false --- lib/stream.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/stream.js b/lib/stream.js index fc617ab16..3f85b48f8 100644 --- a/lib/stream.js +++ b/lib/stream.js @@ -65,7 +65,9 @@ function createWebSocketStream(ws, options) { const duplex = new Duplex({ ...options, autoDestroy: false, - emitClose: false + emitClose: false, + objectMode: false, + writableObjectMode: false }); ws.on('message', function message(msg) {