extending ws to support 48bit values #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Nov 16, 2021
… and fine tune the sender payload length
lpinca
approved these changes
Nov 16, 2021
|
Thank you. |
|
FWIW, the largest size allowed for a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ws library is using 32 bit values on the read and write for payload length. This is because web sockets supports 63 bit payload lengths if the payload flag is 127 but JavaScript's max number is 53 bits - 1.
Node.js supports a 48 bit read and write operation. The maximum payload length supported by 32 bits is 2.1gb. The maximum payload length supported by 48 bits is 281tb.
Is there test automation or CI I can run this against?