New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does ws work with express-status-monitor #1664
Comments
The underlying issue is the same of #1660. It's invalid usage. There must be a 1:1 correspondence between a |
Thank you for the quick response! Do you know any monitoring tools that could be used with |
No. it depends on the project but a proper APM like Elastic APM https://www.elastic.co/guide/en/apm/agent/nodejs/current/express.html might be better. In the example above is there any reason to create your own WebSocket server? As far as I can see, it is possible to create a socket.io server externally and pass it to |
I need to monitor the health of websocket server so it's handy to attach health route to that server in order to monitor it and restart if needed. That's why I need websocket to use express server. |
Closing as answered. Discussion can continue if needed. |
issue.
Description
When using
ws
with express and adding express-status-monitor npm package as middleware, the server crashes with the following error:Reproducible in:
Steps to reproduce:
Expected result:
server doesn't crash
Actual result:
server crashes
Attachments:
The text was updated successfully, but these errors were encountered: