Cannot set property 'readyState' of undefined #1564

mccoysc · 2019-05-12T13:00:45Z

websocket.readyState = WebSocket.CLOSING;
^

TypeError: Cannot set property 'readyState' of undefined
at TLSSocket.socketOnClose (/node_modules/ws/lib/websocket.js:826:24)
at TLSSocket.emit (events.js:187:15)
at _handle.close (net.js:606:12)
at Socket.done (_tls_wrap.js:386:7)
at Object.onceWrapper (events.js:273:13)
at Socket.emit (events.js:182:13)
at TCP._handle.close (net.js:606:12)

mccoysc · 2019-05-12T13:54:18Z

@lpinca i found that as a server:
if 2 or more clients(some app run in browser) are connected to this server,and if one client closed,the error would be occoured in server side.

mccoysc · 2019-05-12T13:57:16Z

https://careeron.ecspool.com
you can browse this url in 2 browser tab.
refresh one tab,the another tab's websocket connection would be in "CLOSED" state(in fact,the server side is errored at this moment)

lpinca · 2019-05-12T14:16:28Z

I can't see how this can happen:

The socketOnClose() listener is added by WebSocket#setSocket() after socket[kWebSocket] = this;
How can websocket be undefined when the listener is called?

Please create a minimal test case, using only ws, to reproduce the issue.

mccoysc · 2019-05-12T14:28:05Z

i found that for one same websocket,the socketOnClose function is called twice:for the first,you have make "this[kWebSocket]=undefined",and so the seconed,this[kWebSocket] is undefined

mccoysc · 2019-05-12T14:28:41Z

@lpinca

lpinca · 2019-05-12T14:33:05Z

If the 'close' event is emitted more than once on the net.Socket or tls.Socket then there is a bug in Node.js.

Also the listener removes itself after it is called. See https://github.com/websockets/ws/blob/6.2.1/lib/websocket.js#L823

mccoysc · 2019-05-12T14:41:46Z

but how can i resolve this problem?

lpinca · 2019-05-12T14:43:53Z

I don't know. Show me where the bug is in ws and how to reproduce it then maybe I can help. I have no clue what your code is doing.

mccoysc · 2019-05-12T15:07:45Z

but what ever,the Websocket should not be crashed 发自我的iPhone

…

------------------ Original ------------------ From: Luigi Pinca <notifications@github.com> Date: Sun,May 12,2019 10:44 PM To: websockets/ws <ws@noreply.github.com> Cc: mccoysc <364589886@qq.com>, Author <author@noreply.github.com> Subject: Re: [websockets/ws] Cannot set property 'readyState' of undefined (#1564) I don't know. Show me where the bug is in ws and how to reproduce it then maybe I can help. I have no clue what your code is doing. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

lpinca · 2019-05-12T15:31:12Z

I cannot make it crash and that's why I'm asking you to write a test case to reproduce the issue. This is what I tried with the info you gave me and it works as expected, no exception is thrown.

const WebSocket = require('.');
const { createServer } = require('https');
const { readFileSync } = require('fs');

const server = createServer({
  cert: readFileSync('test/fixtures/certificate.pem'),
  key: readFileSync('test/fixtures/key.pem')
});
const wss = new WebSocket.Server({ server });

wss.on('connection', function(ws, { url }) {
  const params = new URLSearchParams(url.slice(url.indexOf('?')));

  ws.on('close', function() {
    console.log('closed connection %s', params.get('id'));
  });
});

server.listen(8080, function() {
  const options = { rejectUnauthorized: false };
  const ws1 = new WebSocket('wss://localhost:8080/?id=1', options);
  const ws2 = new WebSocket('wss://localhost:8080/?id=2', options);

  ws1.on('open', function() {
    ws1.close();
  });

  ws2.on('open', function() {
    ws2.close();
  });
});

mccoysc · 2019-05-12T15:52:11Z

careerOnDapp.zip

mccoysc · 2019-05-12T15:52:17Z

you can run:
node ./bin/www

and browse at
https://127.0.0.1
in 2 tabs.
and refresh one tab,
the program would be crashed

lpinca · 2019-05-12T16:02:49Z

It does not crash on my machine.

mccoysc · 2019-05-12T16:03:49Z

you browser url https://127.0.0.1
and then browse the same url in another tab.

and then you refresh one tab

lpinca · 2019-05-12T16:07:36Z

yes, also this is not a good test case. It's a whole app can't even see where ws is used. Where is the WebSocket server created?

$ grep --exclude-dir=node_modules -R -E "require\('ws" .

ws is not used anywhere.

mccoysc · 2019-05-12T16:08:43Z

in "node_modules/gun/lib/ws.js"

lpinca · 2019-05-12T16:16:23Z

I don't have time to debug other people code, sorry. I have no clue what gun does with ws and how it uses it. Report the issue on gun repository.

Btw I tried again and it does not crash on my machine. I've opened 3 tabs and refreshed all of them.

lpinca · 2019-05-12T17:12:46Z

What Node.js version are you using? What OS?

mccoysc · 2019-05-12T23:34:04Z

Nodejs v11.9 and v10.11.0 Os:win10 and centOS 6.8

…

------------------ Original ------------------ From: Luigi Pinca <notifications@github.com> Date: Mon,May 13,2019 1:13 AM To: websockets/ws <ws@noreply.github.com> Cc: mccoysc <364589886@qq.com>, Author <author@noreply.github.com> Subject: Re: [websockets/ws] Cannot set property 'readyState' of undefined (#1564) What Node.js version are you using? What OS? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

lpinca · 2019-05-13T20:47:16Z

Closing as I can't reproduce it.

nooop3 · 2019-06-28T03:44:07Z

may be emit 'close' multi times.
Node.JS removelistener

orgads · 2019-07-17T06:04:57Z

We hit a similar exception when 'error' event is received after 'close'. It happens if I have an open websocket, and I'm profiling with Chrome. When I click "Stop recording heap profile", it pauses the application for a few seconds, and this leads to a crash (sometimes).

I don't have a minimal example that reproduces it yet, but I'll try to reproduce later today.

Trace:

socketOnError (f:\Project\node_modules\ws\lib\websocket.js:904)
emit (events.js:198)
EventEmitter.emit (domain.js:448)
errorOrDestroy (destroy.js:107)
onwriteError (_stream_writable.js:430)
onwrite (_stream_writable.js:461)
doWrite (_stream_writable.js:411)
clearBuffer (_stream_writable.js:522)
Writable.uncork (_stream_writable.js:319)
sendFrame (f:\Project\node_modules\ws\lib\sender.js:353)
perMessageDeflate.compress (f:\Project\node_modules\ws\lib\sender.js:311)
_compress (f:\Project\node_modules\ws\lib\permessage-deflate.js:315)
_deflate.flush (f:\Project\node_modules\ws\lib\permessage-deflate.js:449)
afterWrite (_stream_writable.js:485)
onwrite (_stream_writable.js:476)
afterTransform (_stream_transform.js:94)
processCallback (zlib.js:548)
[ ZLIB ]
init (inspector_async_hook.js:27)
emitInitNative (async_hooks.js:137)

lpinca · 2019-07-17T06:08:44Z

@orgads see #1591

orgads · 2019-07-19T14:33:56Z

Thank you. That was it.

raifemre · 2020-03-28T13:57:48Z

I introduced the same problem and found out that other libraries somehow breaks the connection on express server. On my case it was 'express-status-monitor'.

wenzhiwang · 2020-03-30T03:17:08Z

I introduced the same problem and found out that other libraries somehow breaks the connection on express server. On my case it was 'express-status-monitor'.

I ran into the same problem yesterday when I played with the Hackathon Starter. The "express-status-monitor" breaks the connection, indeed.

mredbishop · 2020-08-28T13:13:07Z

Why is this closed, regardless of why the event is being fired twice it shouldn't crash the entire app. If it's possible for the websocket not to be defined then the method should account for it. In this case it most likely should just return early.

lpinca · 2020-08-28T13:17:44Z

Why is this closed, regardless of why the event is being fired twice it shouldn't crash the entire app. If it's possible for the websocket not to be defined then the method should account for it. In this case it most likely should just return early.

No, because if we do it we mask a bug instead of fixing it. The websocket cannot be undefined in that handler. If it is there is bug.

mredbishop · 2020-08-28T13:50:27Z

Why is this closed, regardless of why the event is being fired twice it shouldn't crash the entire app. If it's possible for the websocket not to be defined then the method should account for it. In this case it most likely should just return early.

No, because if we do it we mask a bug instead of fixing it. The websocket cannot be undefined in that handler. If it is there is bug.

Maybe I'm misunderstanding but it is literally this method that sets the websocket to undefined, if it's already been called it should do nothing. There is no way to handle this error gracefully from the outside and the cause of it is in another library. How do you propose someone deals with this, as in our case it is recycling a live service whenever it happens?

lpinca · 2020-08-28T13:59:47Z

There is no way to handle this error gracefully from the outside and the cause of it is in another library.

That error must not be handled gracefully. It should crash the process. We can put an assert(this[kWebSocket]); like it's done here https://github.com/nodejs/node/blob/v14.9.0/lib/_http_client.js#L507 or here https://github.com/nodejs/node/blob/v14.9.0/lib/_http_client.js#L700 for example but the result would be the same.

How do you propose someone deals with this, as in our case it is recycling a live service whenever it happens?

Fix the problem that is causing it. Fix the invalid usage of ws.

mredbishop · 2020-08-28T14:18:39Z

So as far as I can tell the handler is attached twice, which means the "upgrade" handler has run multiple times. Have you got any suggestions on where to look to try and get this issue resolved?

lpinca · 2020-08-28T14:32:52Z

Read my comments here #1787, they should help you.

wizzfizz94 · 2021-07-09T02:26:00Z

For me the error was thrown because I failed to remove the upgrade listener from my http server after closing a noServer web socket server. Make sure you hold a reference to the upgrade callback that you can remove later when closing the connection. E.g.

   // setup
   this.wsServer = new ws.Server({
      noServer: true
   })

  // upgrade cbk init
  this.upgradeCbk = (request, socket, head) => {
    const pathname = url.parse(request.url).pathname;
    if (pathname === this.path) {
      this.wsServer.handleUpgrade(request, socket, head, ws => {
        this.wsServer.emit('connection', ws, request);
      });
    }
  }

  this.server.on('upgrade', this.upgradeCbk);

  // later on when shutting down ws server
  this.wsServer.close()
  this.server.removeListener("upgrade", this.upgradeCbk)

lpinca closed this as completed May 13, 2019

lpinca mentioned this issue Jul 12, 2019

if this[kWebSocket] = undefined , then must check it exists else where #1606

Closed

Hugome mentioned this issue Oct 25, 2019

node crash when antoher normal moleculer node running moleculerjs/moleculer-apollo-server#51

Closed

Siedlerchr mentioned this issue Nov 12, 2019

TypeError: Cannot set property 'readyState' of undefined (when using upgrade listener) #1660

Closed

1 task

mo22 mentioned this issue Mar 4, 2020

TypeError: Cannot set property 'readyState' of undefined resurfaced? #1704

Closed

lpinca mentioned this issue Aug 28, 2020

Prevent server crash on duplicate close event. #1789

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot set property 'readyState' of undefined #1564

Cannot set property 'readyState' of undefined #1564

mccoysc commented May 12, 2019

mccoysc commented May 12, 2019

mccoysc commented May 12, 2019

lpinca commented May 12, 2019 •

edited

mccoysc commented May 12, 2019

mccoysc commented May 12, 2019

lpinca commented May 12, 2019 •

edited

mccoysc commented May 12, 2019

lpinca commented May 12, 2019

mccoysc commented May 12, 2019 via email

lpinca commented May 12, 2019 •

edited

mccoysc commented May 12, 2019

mccoysc commented May 12, 2019

lpinca commented May 12, 2019

mccoysc commented May 12, 2019

lpinca commented May 12, 2019

mccoysc commented May 12, 2019 •

edited

lpinca commented May 12, 2019 •

edited

lpinca commented May 12, 2019

mccoysc commented May 12, 2019 via email

lpinca commented May 13, 2019

nooop3 commented Jun 28, 2019

orgads commented Jul 17, 2019

lpinca commented Jul 17, 2019

orgads commented Jul 19, 2019

raifemre commented Mar 28, 2020

wenzhiwang commented Mar 30, 2020

mredbishop commented Aug 28, 2020

lpinca commented Aug 28, 2020 •

edited

mredbishop commented Aug 28, 2020

lpinca commented Aug 28, 2020 •

edited

mredbishop commented Aug 28, 2020

lpinca commented Aug 28, 2020

wizzfizz94 commented Jul 9, 2021

Cannot set property 'readyState' of undefined #1564

Cannot set property 'readyState' of undefined #1564

Comments

mccoysc commented May 12, 2019

mccoysc commented May 12, 2019

mccoysc commented May 12, 2019

lpinca commented May 12, 2019 • edited

mccoysc commented May 12, 2019

mccoysc commented May 12, 2019

lpinca commented May 12, 2019 • edited

mccoysc commented May 12, 2019

lpinca commented May 12, 2019

mccoysc commented May 12, 2019 via email

lpinca commented May 12, 2019 • edited

mccoysc commented May 12, 2019

mccoysc commented May 12, 2019

lpinca commented May 12, 2019

mccoysc commented May 12, 2019

lpinca commented May 12, 2019

mccoysc commented May 12, 2019 • edited

lpinca commented May 12, 2019 • edited

lpinca commented May 12, 2019

mccoysc commented May 12, 2019 via email

lpinca commented May 13, 2019

nooop3 commented Jun 28, 2019

orgads commented Jul 17, 2019

lpinca commented Jul 17, 2019

orgads commented Jul 19, 2019

raifemre commented Mar 28, 2020

wenzhiwang commented Mar 30, 2020

mredbishop commented Aug 28, 2020

lpinca commented Aug 28, 2020 • edited

mredbishop commented Aug 28, 2020

lpinca commented Aug 28, 2020 • edited

mredbishop commented Aug 28, 2020

lpinca commented Aug 28, 2020

wizzfizz94 commented Jul 9, 2021

lpinca commented May 12, 2019 •

edited

lpinca commented May 12, 2019 •

edited

lpinca commented May 12, 2019 •

edited

mccoysc commented May 12, 2019 •

edited

lpinca commented May 12, 2019 •

edited

lpinca commented Aug 28, 2020 •

edited

lpinca commented Aug 28, 2020 •

edited