Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WebSocket#{p{i,o}ng,send}() behavior #1532

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Change WebSocket#{p{i,o}ng,send}() behavior #1532

merged 1 commit into from
Apr 25, 2019

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Mar 17, 2019

  • If the readyState attribute is CONNECTING, throw an exception.
  • If the readyState attribute is CLOSING or CLOSED
    • Increase the bufferedAmount attribute by the length of the data
      argument in bytes.
    • If specified, call the callback function with an error.

Fixes #1515

- If the `readyState` attribute is `CONNECTING`, throw an exception.
- If the `readyState` attribute is `CLOSING` or `CLOSED`
  - Increase the `bufferedAmount` attribute by the length of the `data`
    argument in bytes.
  - If specified, call the `callback` function with an error.

Fixes #1515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send on a closed WebSocket should not throw an exception
1 participant