[feature]: zlib deflate concurrency limit #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STRML
force-pushed
the
feature/zlib-queue
branch
from
4ec7b28
to
3833221
Compare
lpinca
approved these changes
Sep 11, 2017
lib/PerMessageDeflate.js
Outdated
| @@ -4,12 +4,21 @@ const safeBuffer = require('safe-buffer'); | |||
| const zlib = require('zlib'); | |||
|
|
|||
| const bufferUtil = require('./BufferUtil'); | |||
| const Limiter = require('async-limiter'); | |||
There was a problem hiding this comment.
Can you please move this to the above block?
lib/PerMessageDeflate.js
Outdated
| * | ||
| * @param {Buffer} data Compressed data | ||
| * @param {Boolean} fin Specifies whether or not this is the last fragment | ||
| * @param {Function} callback Callback | ||
| * @public | ||
| */ | ||
| decompress (data, fin, callback) { | ||
| zlibLimiter.push((done) => { | ||
| this._decompress(data, fin, function (err, result) { |
There was a problem hiding this comment.
Mind to use arrow functions for consistency?
lib/PerMessageDeflate.js
Outdated
| */ | ||
| compress (data, fin, callback) { | ||
| zlibLimiter.push((done) => { | ||
| this._compress(data, fin, function (err, result) { |
package.json
Outdated
| @@ -26,6 +26,7 @@ | |||
| "lint": "eslint ." | |||
| }, | |||
| "dependencies": { | |||
| "async-limiter": "^1.0.0", | |||
There was a problem hiding this comment.
Can you please use the same versioning scheme?
STRML
force-pushed
the
feature/zlib-queue
branch
from
3833221
to
946edc2
Compare
|
Great - fixed nits. |
|
Thank you. |
This was referenced Sep 15, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1202
Built on top of async-limiter which is only 1kB of dependency-free ES5.