Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly gate TLS error variants in Display impl #267

Merged
merged 1 commit into from Mar 31, 2022
Merged

Properly gate TLS error variants in Display impl #267

merged 1 commit into from Mar 31, 2022

Conversation

newpavlov
Copy link
Contributor

Without the gating websocket fails to compile if neither of the TLS features is enabled.

@vi vi merged commit 40e290a into websockets-rs:master Mar 31, 2022
@newpavlov newpavlov deleted the patch-1 branch March 31, 2022 11:11
@newpavlov
Copy link
Contributor Author

@vi
Could you please cut a release with this fix? I have a project which fails to compile due to indirect dependency on websocket.

@vi
Copy link
Member

vi commented Mar 31, 2022

Published 0.26.4.
But it is still recommended to abandon websocket dependency in favour of e.g. tungstenite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newpavlov @vi