Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rustls for easier cross compiling #238

Open
shekohex opened this issue Jul 20, 2019 · 6 comments
Open

Support rustls for easier cross compiling #238

shekohex opened this issue Jul 20, 2019 · 6 comments

Comments

@shekohex
Copy link

Hi 馃憢

TL;DR: i'm currently using this great crate in my projects (as a client for now) and recently i had to containerize my package into (docker container), that is not a problem, the problem is i want to use musl libc so i can build a static minimum bare-metal image.

using rustls would make cross compiling a way better, so any plans to support it under a feature flag ? maybe async-rustls and sync-rustls ?

Thank you all for your great work 馃憤

@MightyPork
Copy link

I'm currently in a situation where having native-tls breaks compatibility with different target machines (different versions of Debian), and removing the OpenSSL dependency is the only fix, beside trying to build and link OpenSSL statically. This would be an extremely welcome addition.

For now I work around the problem by disabling the tls feature in this crate altogether, but I'm certain it will be needed later. You may find the related reqwest issue and PR of interest.

Thanks for the crate, it's really useful.

@timvisee
Copy link
Contributor

I'd like RusTLS support as well for use in ffsend-api.

Any plans for this?

@vi
Copy link
Member

vi commented May 17, 2020

Any plans for this?

Theoretically yes, but in practice this crate is only seldomly and passively maintained.

Have you tried another WebSocket solutions for Rust?

By leveraging websocket-base you can also use rust-websocket on top of arbitrary underlying protocols (such as UNIX domain sockets), so it can be used to integrate it with rustls. Or maybe it can be done even without websocket-base...

@victorpaleologue
Copy link

victorpaleologue commented May 10, 2022

Have you tried another WebSocket solutions for Rust?

Would you recommend one, please?

Theoretically yes, but in practice this crate is only seldomly and passively maintained.

Can we do something about it?

@victorpaleologue
Copy link

I got a secure websocket working using tokio-tungstenite, with the rustls feature enabled.

@vi
Copy link
Member

vi commented May 11, 2022

Websocat3 (a work in progress, not the recommended build of Websocat) indeed uses tokio-tungstenite and can be built with Rustls (in fact, some of pre-build executables in Github Releases are built with Rustls).

Websocat1 is unlikely to gain Rustls support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants