custom dispatcher pings/timeouts #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d except TimeoutError - raise WebSocketTimeoutException
…ent compatibility): WrappedDispatcher (for use with generic event dispatchers such as pyevent and rel); create_dispatcher() accepts dispatcher kwarg (default None), and if it is specified, returns a WrappedDispatcher; use create_dispatcher() (passing specified dispatcher if any) every time (regardless of dispatcher specification)
pssolanki111
approved these changes
Feb 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
==========================================
- Coverage 84.54% 84.45% -0.09%
==========================================
Files 13 13
Lines 1281 1293 +12
Branches 273 275 +2
==========================================
+ Hits 1083 1092 +9
- Misses 125 129 +4
+ Partials 73 72 -1
Continue to review full report at Codecov.
|
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things:
_socket.recv() error handling
a) fixed socket.error except logic (_socket.py line 95) - I believe the line substituted fulfills the intention of the three lines replaced
b) throw WebSocketTimeoutException on TimeoutError
custom dispatchers (_app.WrappedDispatcher)
a) fixes pyevent integration - calls read() w/ correct arguments
b) simplifies rel integration - no need for rel.safe_read()
c) supports ping_timeout/ping_interval via dispatcher.timeout() w/ check_callback(), if ping_timeout specified
So these changes should make the two modes (standard and w/ custom dispatcher) functionally equivalent in these ways. That is, if you decide to start or stop using a custom dispatcher, your ping_timeout/ping_interval handling won't change (check() function in _app is still called), and your application won't have to handle any new exceptions (such as TimeoutError, which is now expressed as WebSocketTimeoutException).