Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for asset nullity before fileFilter #9701

Merged
merged 1 commit into from Sep 13, 2019
Merged

fix: check for asset nullity before fileFilter #9701

merged 1 commit into from Sep 13, 2019

Conversation

Akryum
Copy link
Contributor

@Akryum Akryum commented Sep 13, 2019

Related: vuejs/vue-cli#4572

What kind of change does this PR introduce?

Bugfix

Did you add tests for your changes?

Not sure how to get a minimum reproduction of this case but it's an emergency fix.

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

N/A

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@alexander-akait
Copy link
Member

Other potential broken place

for (const { name, source, info } of compilation.getAssets()) {

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@Akryum
Copy link
Contributor Author

Akryum commented Sep 13, 2019

Other potential broken place

for (const { name, source, info } of compilation.getAssets()) {

Not sure about this one, getAssets shouldn't return null items I guess

@sokra sokra closed this Sep 13, 2019
@sokra sokra reopened this Sep 13, 2019
@sokra sokra merged commit 705a3f5 into webpack:master Sep 13, 2019
@Akryum Akryum deleted the patch-1 branch September 13, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants