add emit/updateAsset to Compilation #9687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add asset info with * immutable for long term cache-able asset * size for the asset size in bytes * development for devtools * hotModuleReplacement for HMR assets show asset info in stats
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
| this.assets[file] = newSourceOrFunction(this.assets[file]); | ||
| } else { | ||
| this.assets[file] = newSourceOrFunction; | ||
| } |
There was a problem hiding this comment.
It seems making use of ternary operator here would be much better 🤔
this.assets[file] =
typeof newSourceOrFunction === "function" ?
newSourceOrFunction(this.assets[file]) :
newSourceOrFunction;
|
I've created an issue to document this in webpack/webpack.js.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add asset info with
show asset info in stats
fixes #9038
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
It's backward-compatible with the current way of adding or reading assets.
What needs to be documented once your changes are merged?
stats json has
infofor assets now, which contains the asset info.