Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize eslint script #9613

Merged
merged 4 commits into from Aug 22, 2019
Merged

optimize eslint script #9613

merged 4 commits into from Aug 22, 2019

Conversation

shaodahong
Copy link
Contributor

What kind of change does this PR introduce?
Fixes #9612

Did you add tests for your changes?
Yes

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@montogeek
Copy link
Member

montogeek commented Aug 21, 2019

Please respect original configuration, that command only care about those specific tests. But maybe that is not the case anymore...

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@shaodahong
Copy link
Contributor Author

@montogeek I know and I respect original configuration, this is my idea, just I think .eslintignore is friendly. if this config not suitable, I will be close it

.eslintignore Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@webpack-bot
Copy link
Contributor

@shaodahong Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@shaodahong
Copy link
Contributor Author

@sokra test/helper/*.js should use code-lint script ?

@sokra
Copy link
Member

sokra commented Aug 22, 2019

@sokra test/helper/*.js should use code-lint script ?

yep

@sokra sokra merged commit 9dc49cf into webpack:master Aug 22, 2019
@sokra
Copy link
Member

sokra commented Aug 22, 2019

Thanks

@shaodahong shaodahong deleted the optimize-eslint branch October 10, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize code-lint
4 participants