Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed automaticPrefetchPlugin to not apply loaders via config to the request #9492

Merged
merged 2 commits into from Jan 13, 2021

Conversation

nveenjain
Copy link
Member

@nveenjain nveenjain commented Jul 30, 2019

Fixes #9485

What kind of change does this PR introduce?
BugFix

Did you add tests for your changes?
NA

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the difficult part of adding a test case

@nveenjain
Copy link
Member Author

@sokra , I tried changing format of HotTestCases, and WatchTestCases, but loader gets applied when i require the module, how can i test this? Could you please guide me, I'm stuck?

@sokra sokra force-pushed the fix/AutomaticPrefetchPlugin branch from 2959461 to 684d375 Compare January 13, 2021 15:50
@sokra sokra merged commit 9b53ae5 into webpack:master Jan 13, 2021
@sokra
Copy link
Member

sokra commented Jan 13, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After change file .js (import (css, less, scss)), webpack result is error.
3 participants