Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the second parameter of cleverMerge could be undefined #9424

Closed
1234567vgt opened this issue Jul 17, 2019 · 7 comments · Fixed by #9425
Closed

the second parameter of cleverMerge could be undefined #9424

1234567vgt opened this issue Jul 17, 2019 · 7 comments · Fixed by #9425

Comments

@1234567vgt
Copy link

Do you want to request a feature or report a bug?
bug， the second parameter of cleverMerge could be undefined

image

What is the current behavior?

In https://github.com/amireh/happypack/blob/master/lib/WebpackUtils.js#L137， resolverFactory.get("loader") miss the second parameter，and then cause the problem above

image

If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?

If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
@alexander-akait
Copy link
Member

How we can reproduce bug?

@neoimale

This comment has been minimized.

Sign in to view
sokra added a commit that referenced this issue Jul 17, 2019
@sokra
fix #9424
1f966eb 
remove unused code
@sokra sokra mentioned this issue Jul 17, 2019
Merged
@sokra
Copy link
Member

sokra commented Jul 17, 2019 •
edited

The second argument is actually required. Unsure why it's omitted here by happypack. Anyway fix is on the way...

@BH-M87

This comment has been minimized.

Sign in to view
1 similar comment
@BH-M87

This comment has been minimized.

Sign in to view
@ffjanhoeck

This comment has been minimized.

Sign in to view
@webpack webpack locked as resolved and limited conversation to collaborators Jul 17, 2019
sokra added a commit that referenced this issue Jul 17, 2019
@sokra
Merge pull request #9425 from webpack/bugfix/no-resolve-options
4cac066 
fix #9424
@sokra
Copy link
Member

sokra commented Jul 17, 2019

releases as 4.36.1

@webpack webpack unlocked this conversation Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #9424 webpack/webpack
6 participants
@sokra @neoimale @alexander-akait @ffjanhoeck @BH-M87 @1234567vgt