Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve merging of resolve and parsing options #9422

Merged
merged 1 commit into from Jul 17, 2019

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 17, 2019

by rules and via loader API

Arrays overwrite by default, but can reference old value with "..."

partial backport of #9126

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
Merging of Rule.resolve/Rule.parser objects has a new feature:
In array the special "..." item can now be used to reference to old value, while otherwise array values overwrite each other.
This also affects the getResolve(options) API in the loader API

by rules and via loader API

Arrays overwrite by default, but can reference old value with "..."
@webpack-bot
Copy link
Contributor

webpack-bot commented Jul 17, 2019

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

I've created an issue to document this in webpack/webpack.js.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants