add output.futureEmitAssets #8642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a new version of emitting assets which allows to free memory of Sources with the trade-off of disallowing reading asset content after emitting It also uses Source.buffer when available.
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
dav-is
approved these changes
Jan 17, 2019
|
When using the flag on a development build, it freezes on |
ooflorent
approved these changes
Jan 18, 2019
|
You don't have to use |
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Jan 22, 2019
This version (https://github.com/webpack/webpack/releases/tag/v4.29.0) includes a memory leak fix for assets (webpack/webpack#8609, webpack/webpack#8642). Thanks to @Meligy for pinging about this!
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this pull request
Jan 22, 2019
This version (https://github.com/webpack/webpack/releases/tag/v4.29.0) includes a memory leak fix for assets (webpack/webpack#8609, webpack/webpack#8642). Thanks to @Meligy for pinging about this!
mgechev
pushed a commit
to angular/angular-cli
that referenced
this pull request
Jan 22, 2019
This version (https://github.com/webpack/webpack/releases/tag/v4.29.0) includes a memory leak fix for assets (webpack/webpack#8609, webpack/webpack#8642). Thanks to @Meligy for pinging about this!
5 tasks
redbugz
added a commit
to fs-webdev/create-react-app
that referenced
this pull request
Apr 27, 2019
CRA 3 opts-in to a new webpack 5 feature early to save memory: `futureEmitAssets` facebook#6696 This optimization only stores the file sizes during webpack compilation, no longer storing the original source webpack/webpack#8642 This is incompatible with our webpack-dev-server customization setting of `writeToDisk` webpack/webpack#8642 (comment) which tries to read the source after emit, which throws an exception, but that error is swallowed and the `npm start` just hangs. Before we update to webpack 5, where this feature will be the default, we need to stop writing to disk, or find another way to do it than the `writeToDisk` flag.
Merged
3 tasks
ikjelle
pushed a commit
to ikjelle/angular-cli
that referenced
this pull request
Mar 26, 2024
This version (https://github.com/webpack/webpack/releases/tag/v4.29.0) includes a memory leak fix for assets (webpack/webpack#8609, webpack/webpack#8642). Thanks to @Meligy for pinging about this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new version of emitting assets which allows to free memory of Sources with the trade-off of disallowing reading asset content after emitting
It also uses Source.buffer when available.
What kind of change does this PR introduce?
memory
Did you add tests for your changes?
no (it will be tested in the next branch, when it's on by default)
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
New option
output.futureEmitAssetsallows to opt-in to the new way of emitting assets which allows to free memory of Sources with the trade-off of disallowing reading asset content after emitting