Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in Chunk#split jsdoc comment #8351

Merged
merged 1 commit into from Nov 14, 2018

Conversation

DeTeam
Copy link

@DeTeam DeTeam commented Nov 7, 2018

What kind of change does this PR introduce?

typo fix

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@DeTeam
Copy link
Author

DeTeam commented Nov 7, 2018

@TheLarkInn please have a look when you have a moment

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@DeTeam
Copy link
Author

DeTeam commented Nov 12, 2018

It's a bit strange that webpack.webpack failed. Should I rebase or maybe re-trigger the build?

@ooflorent ooflorent closed this Nov 12, 2018
@ooflorent ooflorent reopened this Nov 12, 2018
@DeTeam
Copy link
Author

DeTeam commented Nov 14, 2018

Thanks @ooflorent
Does it mean we can merge this tiny fix now? :)

@sokra sokra merged commit a230148 into webpack:master Nov 14, 2018
@sokra
Copy link
Member

sokra commented Nov 14, 2018

Thanks

@DeTeam DeTeam deleted the chunk-jsdoc-typo branch November 14, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants