add module argument to DefinePlugin.runtimeValue functions #8306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR webpack#6793 added the ability for DefinePlugin to use function that return values. This PR just add the ability to these functions to access the module being parsed (see webpack#8301). eg. ``` webpack.DefinePlugin.runtimeValue(module => module.resource ....) ```
|
|
|
For maintainers only:
|
FranckFreiburger
force-pushed
the
master
branch
from
c71b36a
to
2b0025a
Compare
sokra
approved these changes
Oct 30, 2018
|
current test is |
sokra
requested changes
Oct 31, 2018
Co-Authored-By: FranckFreiburger <FranckFreiburger@users.noreply.github.com>
|
@FranckFreiburger Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Just a little hint from a friendly bot about the best practice when submitting pull requests:
You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR. |
sokra
approved these changes
Oct 31, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6793 added the ability for DefinePlugin to use function that return values.
This PR just add the ability to these functions to access the module being parsed (see #8301).
eg.
issue #8301
What kind of change does this PR introduce?
It adds a
modulean argument to fct in DefinePlugin.runtimeValue(fct)Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
About the additional
moduleargument