fix: disable ProvidePlugin for javascript/esm (fixes #7032) #8250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
reviewed
Oct 22, 2018
lib/ProvidePlugin.js
Outdated
| .tap("ProvidePlugin", handler); | ||
|
|
||
| // Disable ProvidePlugin for javascript/esm, see https://github.com/webpack/webpack/issues/7032 | ||
| // normalModuleFactory.hooks.parser |
There was a problem hiding this comment.
remove the commented code, leave only a note why it's not enabled
|
For maintainers only:
|
aladdin-add
changed the title
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@aladdin-add Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
|
@sokra I updated the test case in |
aladdin-add
changed the title
sokra
requested changes
Oct 30, 2018
| @@ -10,7 +10,8 @@ module.exports = { | |||
| es2015_name: ["./harmony", "default"], | |||
| es2015_alias: ["./harmony", "alias"], | |||
| es2015_year: ["./harmony", "year"], | |||
| "this.aaa": "./aaa" | |||
| "this.aaa": "./aaa", | |||
| esm: "./fff.mjs" | |||
There was a problem hiding this comment.
change this to esm: "fail"
import fff.mjs from index.js.
Use esm in fff.mjs. It should not be replaced. i. e.
export function() {
return esm;
}Currently you are not testing your change.
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
webpack-bot
added
PR: review-outdated
PR: CI-not-ok
and removed
PR: reviewed-changes-requested
PR: CI-ok
labels
Signed-off-by: weiran.zsd <weiran.zsd@alibaba-inc.com>
|
Thank you for your pull request! The most important CI builds succeeded, we鈥檒l review the pull request soon. |
sokra
requested changes
Oct 31, 2018
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
Co-Authored-By: Aladdin-ADD <weiran.zsd@outlook.com>
sokra
approved these changes
Nov 5, 2018
|
Thanks |
sokra
added a commit
that referenced
this pull request
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7032
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
updated a test case.
Does this PR introduce a breaking change?
not sure, I guess no. 馃槃
What needs to be documented once your changes are merged?