Make changes suggested by @sokra to optimize chunk graph generation #8143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses concerns in #8126 by attempting to implement suggestions from @sokra to optimize
Compilation.processDependenciesBlocksForChunkGroups
..filter()
to allocate a new array (lines 1870-1879)areModulesAvailable()
call when a chunk has already survived a filter. (lines 1818-1823).I've probably mangled sokra's ideas beyond recognition, but opening this PR so he can more easily comment on what I should do. Currently, I'm not actually seeing perf improvements from these changes.
What kind of change does this PR introduce?
Performance improvement (without any intended behavioral change)
Did you add tests for your changes?
No; as a perf change with no behavior change, I rely on the existing tests
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
N/A