Uncaught exception from renderers #8070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 4.19.0, exceptions thrown by plugins that hooked any of the bootstrap rendering events (e.g.
beforeStartup
,requireEnsure
, etc.) were caught and the error message was added tocompilation.errors
. This occurred because compilation.createChunkAssets() has a try/catch block that catches and processes exceptions thrown by the renderers.Starting with 4.19.0, the bootstrap rendering code is now also called via compilation.createHash(). Any exceptions thrown by the rendering code from this call are not caught and the exceptions propagates up to node and the application is terminated.
This pr adds exception handling code to compilation.createHash() that is similar to what compilation.createChunkAssets() does so that exceptions thrown by bootstrap rendering code will be handled in a similar way.
What kind of change does this PR introduce?
Improves exception handling
bugfix
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
no documentation needed