Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set the 'browser' value for electron-renderer #8038

Merged
merged 1 commit into from Sep 17, 2018
Merged

Correctly set the 'browser' value for electron-renderer #8038

merged 1 commit into from Sep 17, 2018

Conversation

sharang-d
Copy link
Contributor

Fixes #8031.

@sokra Does this change need a test? If so then can you point me towards an existing test which I can copy/modify to test this new code?

@jsf-clabot
Copy link

jsf-clabot commented Sep 16, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 2f78aae into webpack:master Sep 17, 2018
@sokra
Copy link
Member

sokra commented Sep 17, 2018

Thanks

@sharang-d sharang-d deleted the patch-5 branch September 17, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sharang-d @jsf-clabot @webpack-bot @sokra