Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash content of bootstrap code #8029

Merged
merged 1 commit into from Sep 13, 2018
Merged

hash content of bootstrap code #8029

merged 1 commit into from Sep 13, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 13, 2018

instead of trying to calculate it
from inputs

fixes #8027
fixes #7984

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
existing tests

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

instead of trying to calculate it
from inputs

fixes #8027
fixes #7984
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit aecdeb3 into master Sep 13, 2018
@sokra sokra deleted the bugfix/hash-bootstrap branch September 13, 2018 21:55
* @returns {void}
*/
updateHashForChunk(hash, chunk) {
updateHashForChunk(hash, chunk, moduleTemplate, dependencyTemplates) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like moduleTemplate and dependencyTemplates is unused...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same chunkhash for different output contenthash changing even though file remains identical
3 participants