Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example.js , newer syntax #7803

Merged
merged 3 commits into from Sep 25, 2018
Merged

Update example.js , newer syntax #7803

merged 3 commits into from Sep 25, 2018

Conversation

oygen87
Copy link
Contributor

@oygen87 oygen87 commented Jul 28, 2018

update to newer syntax

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

update to newer syntax
@jsf-clabot
Copy link

jsf-clabot commented Jul 28, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@ooflorent ooflorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update increment.js and rebuild README.md?

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update README.md in this folder too

@oygen87
Copy link
Contributor Author

oygen87 commented Jul 29, 2018

im not so good on git but i made separate PR for your asked changes

@montogeek
Copy link
Member

In that case, please close all other PRs and edit those file using the same branch using the web interface:

  1. Open https://github.com/oygen87/webpack/tree/patch-1
  2. Navigate to https://github.com/oygen87/webpack/tree/patch-1/examples/commonjs
  3. Open https://github.com/oygen87/webpack/blob/patch-1/examples/commonjs/increment.js
  4. Use Edit icon in the top right corner of the code.
  5. Repeat 3 and 4 step for each file.

@webpack-bot
Copy link
Contributor

@oygen87 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@oygen87
Copy link
Contributor Author

oygen87 commented Jul 29, 2018

thank you for your instructions @montogeek , ive closed the others and updated this one

@sokra sokra merged commit 4ed8c08 into webpack:master Sep 25, 2018
@sokra
Copy link
Member

sokra commented Sep 25, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants