New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct ExternalModule's global option (#6933) #7038
Correct ExternalModule's global option (#6933) #7038
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test case:
In test/configCases
Set externals: { ext: "global external" }
in config
Set the global var just before require("ext")
.
Delete it afterwards to not leak.
For maintainers only:
|
@marcusdarmstrong Let me know if you need further help with any of the comments we've provided. No time pressure, just making sure instructions are clear! |
@TheLarkInn haven’t had a chance to look yet, but I don’t expect difficulty. We’ve been running with this hacked in via the prototype so it’s been lower priority to get it upstreamed, but still on my to-do list. |
Thanks for writing tests for me! |
The basic integration tests failed. @sokra Please review the following output log for errors:
Show remaining errors
See complete report here. |
Thanks |
What kind of change does this PR introduce?
Quick fix for #6933.
Did you add tests for your changes?
No, as there weren't any covering this code to begin with.
If relevant, link to documentation update:
Summary
Currently ExternalModules that have a type of 'global' produce invalid code, as described in #6933. This affects things like the DllPlugin.
Does this PR introduce a breaking change?
No.
Other information