New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added sortModules method to Chunk class #5225
Merged
sokra
merged 2 commits into
webpack:master
from
hulkish:feature/added-chunk-sortModules-method
Jul 6, 2017
Merged
added sortModules method to Chunk class #5225
sokra
merged 2 commits into
webpack:master
from
hulkish:feature/added-chunk-sortModules-method
Jul 6, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Jul 6, 2017
Thanks |
This was referenced Jul 7, 2017
5 tasks
joshwiens
added a commit
to webpack-contrib/extract-text-webpack-plugin
that referenced
this pull request
Jul 10, 2017
- refactor: Pass a unique compiler name to get child compilation [483](#483) - refactor: Apply webpack-defaults [542](#542) BREAKING CHANGE: Enforces `engines` of `"node": ">=4.3.0 < 5.0.0 || >= 5.10` - refactor: DeprecationWarning: Chunk.modules [543](#543) BREAKING CHANGE: Updates to `Chunk.mapModules`. This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764 - fix: css generation order issue see: webpack/webpack#5225 BREAKING CHANGE: Enforces `peerDependencies` of `"webpack": "^3.1.0"`.
This was referenced Oct 5, 2017
This was referenced Feb 2, 2018
This was referenced Jul 31, 2018
This was referenced May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No.
If relevant, link to documentation update:
N/A
Summary
Added
sortModules
method toChunk
class.extract-text-webpack-plugin
is emitting extracted css in the incorrect order in which modules are imported due toChunk._modules
being converted from anArray
to aSet
inwebpack@3
Does this PR introduce a breaking change?
No.