Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sortModules method to Chunk class #5225

Merged

Conversation

hulkish
Copy link
Contributor

@hulkish hulkish commented Jul 6, 2017

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
No.

If relevant, link to documentation update:

N/A

Summary

Added sortModules method to Chunk class.

extract-text-webpack-plugin is emitting extracted css in the incorrect order in which modules are imported due to Chunk._modules being converted from an Array to a Set in webpack@3

Does this PR introduce a breaking change?
No.

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 2879fb3 into webpack:master Jul 6, 2017
@sokra
Copy link
Member

sokra commented Jul 6, 2017

Thanks

joshwiens added a commit to webpack-contrib/extract-text-webpack-plugin that referenced this pull request Jul 10, 2017
- refactor: Pass a unique compiler name to get child compilation [483](#483)
- refactor: Apply webpack-defaults [542](#542)

BREAKING CHANGE: Enforces `engines` of `"node": ">=4.3.0 < 5.0.0 || >= 5.10`

- refactor: DeprecationWarning: Chunk.modules [543](#543)

BREAKING CHANGE: Updates to `Chunk.mapModules`. This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764

- fix: css generation order issue see: webpack/webpack#5225

BREAKING CHANGE: Enforces `peerDependencies` of `"webpack": "^3.1.0"`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants