fix: parser hook calls for compiler plugins #18128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
|
@snitin315 Please see #18113 (comment) and #18149 (comment) Hence: unfortunately no. I am willing to agree to the terms of the CLA but not to the process involved to sign it (specifically providing my real address). |
|
No problem, I'll fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #18113
Did you add tests for your changes?
Yes, I added some new tests to ensure that the hooks are called. Needed to use the whole compiler to ensure all plugins (like InnerGraphPlugin) are registered as expected.
I tried first to extend the JavaScriptParser.unittest.js but it didn't behave like the whole compiler.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No special docs needed I'd say.