-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate breaks in experiments for webpack on performance-benchmark
.
#17036
Comments
I believe since there isn't many integrations that this is caused by: https://github.com/pmmmwh/react-refresh-webpack-plugin |
@TheLarkInn Is it broken? |
I think this plugin breaks when used with |
My concern is that this is a very popular plugin for webpack+react users so we should prioritize futureproofing finding the bugs in the plugin for when we enable these future defaults and features. |
Yeah, agree |
@TheLarkInn @alexander-akait module.exports =
{
node: {
global: false,
},
experiments: {
css:false,
futureDefaults:true
}
} related MR web-infra-dev/performance-compare#3 the performance gain is shown in the following I'm wondering are there any configuration could improve rebuild performance of webpack, the problems we met in rspack when following webpack's rebuild strategy is that it seems the rebuild cost is linear to project's scale (related to module number and chunk number), so we take another approach like parcel's parcel-bundler/parcel#6047 which is faster in some normal edit case. |
See webpack/webpack#17036 (comment) Co-Authored-By: hardfist <1562502418@qq.com>
This issue had no activity for at least three months. It's subject to automatic issue closing if there is no activity in the next 15 days. |
Bump - I'll try to investigate this soon and hopefully we can figure out what's wrong |
bump |
@alexander-akait I investigated it before, it's not related to react-refresh-webpack-plugin, it's caused by futureDefault enable experiments.css by default which conflicts with style-loader, so disable experiments.css could solve this |
@hardfist oh, thank you, I think we need to send a fix there |
Issue was closed because of inactivity. If you think this is still a valid issue, please file a new issue with additional information. |
experments.futureDefaults
&experiments.lazyCompilation
to both babel and swc webpack configurationsnpm run start:webpack
Expected Output:
Actual Outcome:
Console errors related to
lazyCompilation
Console errors related to
futureDefaults
The text was updated successfully, but these errors were encountered: