Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add GitHub token permissions for workflow #16033

Merged
merged 1 commit into from Jul 25, 2022

Conversation

varunsh-coder
Copy link
Contributor

This PR adds minimum token permissions for the GITHUB_TOKEN using https://github.com/step-security/secure-workflows.

GitHub recommends defining minimum GITHUB_TOKEN permissions for securing GitHub Actions workflows

This project is part of the top 100 critical projects as per OpenSSF (https://github.com/ossf/wg-securing-critical-projects), so fixing the token permissions to improve security.

Signed-off-by: Varun Sharma varunsh@stepsecurity.io

What kind of change does this PR introduce?
Build related change

Did you add tests for your changes?
New tests not needed for the change

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Not applicable

Signed-off-by: Varun Sharma <varunsh@stepsecurity.io>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: varunsh-coder / name: Varun Sharma (e9f2195)

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra merged commit 52351a6 into webpack:main Jul 25, 2022
@sokra
Copy link
Member

sokra commented Jul 25, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants