New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass shareScope through to ContainerPlugin & ContainerReferencePlugin #16031
Conversation
|
For maintainers only:
|
Hi @evantd. Just a little hint from a friendly bot about the best practice when submitting pull requests:
You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR. |
It looks like failures are sort of common. I saw a pull request that only changed the readme, and it also had 2 failed checks. I don't think that these failures are related to my change. It doesn't look like I can retry them either, at least as far as I can tell. |
It looks like @sokra and/or @ScriptedAlchemy would be the right people to review this. |
Good catch. Assuming both plugins under the hood still call apply(compiler) - which they should. Then I think this change looks good to me and would ensure plugins still work without having to manually apply 3-4 plugins just to use container or container reference independently |
Yay! Yeah, I'm using an alternate |
Is there anything more that I should be doing to keep this moving forward? |
Since this is approved, should I expect it to be included in the next release? |
Can take a little time to move through the webpack org depending on what the change is. This seems small so I imagine it would be a quicker turnaround. Nice thing about webpack is you can insall it over npm off a git branch since there's no build - so that might be useful in the interm |
Thanks |
I found myself needing to check if my version was new enough, so for anybody else (or future me), this is fixed in 5.74.0. |
It looks to me like setting
shareScope
forModuleFederationPlugin
doesn't work without this change, becauseContainerPlugin
still tries to usedefault
.What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No, but I didn't see any other tests for
ModuleFederationPlugin
either.Does this PR introduce a breaking change?
I don't think so.
What needs to be documented once your changes are merged?
I believe this change makes it more closely match existing documentation.