Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quadratic evaluation performance of async modules #15899

Merged
merged 1 commit into from Jun 2, 2022

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 2, 2022

improve runtime code for async modules

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

improve runtime code for async modules
@sokra sokra force-pushed the bugfix/async-modules-performance branch from 844af68 to 509a060 Compare June 2, 2022 10:37
@sokra sokra merged commit 520d314 into main Jun 2, 2022
@sokra sokra deleted the bugfix/async-modules-performance branch June 2, 2022 11:18
@jsg2021
Copy link

jsg2021 commented Jun 8, 2022

Could this have introduced an edge case that does not resolve?

On 7.73.0 I have a bundle when I import it I see the default key is a pending promise, and it does not appear to resolve.

webpack-5 73 0

but on 5.72.1 it resolves:
webpack-5 72 1

@vankop
Copy link
Member

vankop commented Jun 9, 2022

please create small reproducible repo

@jsg2021
Copy link

jsg2021 commented Jun 9, 2022

please create small reproducible repo

Here you go:
https://github.com/jsg2021/webpak-hanging-bundle-example

@alecmev
Copy link

alecmev commented Jul 30, 2022

@jsg2021 Have you found the cause of this hang? I'm experiencing something similar, but having a hard time narrowing it down. I just know that the problem appeared between 5.72.1 and 5.73.0.

@jsg2021
Copy link

jsg2021 commented Jul 30, 2022

nope. I somehow worked around it.

@alecmev
Copy link

alecmev commented Jul 30, 2022

@jsg2021 Dang... Thanks for the quick reply!

@sokra @vankop Can you take a look at the repro above, please?

@alexander-akait
Copy link
Member

Let's investigate #16097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants