Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more informative error in ProvideSharedPlugin #15873

Merged
merged 1 commit into from Jun 2, 2022
Merged

more informative error in ProvideSharedPlugin #15873

merged 1 commit into from Jun 2, 2022

Conversation

vankop
Copy link
Member

@vankop vankop commented May 30, 2022

What kind of change does this PR introduce?
refactor error message. related to #15864

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra merged commit b8748cf into main Jun 2, 2022
@sokra
Copy link
Member

sokra commented Jun 2, 2022

Thanks

@sokra sokra deleted the more-informative-error branch June 2, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vankop @webpack-bot @sokra