Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor json modules #15801

Merged
merged 3 commits into from Jun 2, 2022
Merged

refactor json modules #15801

merged 3 commits into from Jun 2, 2022

Conversation

vankop
Copy link
Member

@vankop vankop commented May 9, 2022

What kind of change does this PR introduce?
refactoring. fixes #15789

  • do not store exports spec
  • return undefined exports spec for large arrays
  • add memoryLimitCases test cases, this cases allow to test heap size using testConfig.heapSizeLimitBytes

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

lib/dependencies/JsonExportsDependency.js Outdated Show resolved Hide resolved
lib/dependencies/JsonExportsDependency.js Outdated Show resolved Hide resolved
lib/dependencies/JsonExportsDependency.js Outdated Show resolved Hide resolved
@sokra sokra merged commit 096efc3 into main Jun 2, 2022
@sokra sokra deleted the refactor-json-modules branch June 2, 2022 11:15
@sokra
Copy link
Member

sokra commented Jun 2, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default JSON loader uses too much memory
3 participants