Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix HarmonyEvaluatedImportSpecifierDependency #15660

Merged
merged 3 commits into from Apr 19, 2022
Merged

fix HarmonyEvaluatedImportSpecifierDependency #15660

merged 3 commits into from Apr 19, 2022

Conversation

vankop
Copy link
Member

@vankop vankop commented Apr 12, 2022 •
edited

What kind of change does this PR introduce?
fix #15633

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
np

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@vankop vankop changed the title add providedInfo test case fix HarmonyEvaluatedImportSpecifierDependency.js Apr 12, 2022
@vankop vankop changed the title fix HarmonyEvaluatedImportSpecifierDependency.js fix HarmonyEvaluatedImportSpecifierDependency Apr 12, 2022
@vankop vankop force-pushed the add-provided-info-tests branch 3 times, most recently from b3ea6bd to 9b9dc06 Compare April 13, 2022 09:51
@webpack-bot
Copy link
Contributor

@vankop Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@sokra sokra merged commit 293e677 into main Apr 19, 2022
@sokra
Copy link
Member

sokra commented Apr 19, 2022

Thanks

@sokra sokra deleted the add-provided-info-tests branch April 19, 2022 13:06
@vankop vankop mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in-operator broken; "property" in object ALWAYS gets inlined as true
3 participants
@vankop @webpack-bot @sokra