Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw error when using module concatenation and cacheUnaffected #15624

Merged
merged 1 commit into from Apr 5, 2022
Merged

throw error when using module concatenation and cacheUnaffected #15624

merged 1 commit into from Apr 5, 2022

Conversation

vankop
Copy link
Member

@vankop vankop commented Apr 4, 2022

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
nothing

What needs to be documented once your changes are merged?
nothing

@vankop
throw error when using module concatenation and cacheUnaffected
99a5793 
optimization.concatenateModules can't be used with cacheUnaffected as module concatenation is a global effect
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra merged commit cb639b3 into main Apr 5, 2022
@sokra sokra deleted the add-warning-when-cache-unaffected-and-concat-modules branch April 5, 2022 06:02
@sokra
Copy link
Member

sokra commented Apr 5, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vankop @webpack-bot @sokra