add asset modules concatenation #15515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
vankop
force-pushed
the
feat/concatenate-assets
branch
from
96d18b1
to
5f86eb5
Compare
sokra
requested changes
Mar 15, 2022
webpack-bot
added
PR: reviewed-changes-requested
PR: review-outdated
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
vankop
force-pushed
the
feat/concatenate-assets
branch
2 times, most recently
from
1f6d4a1
to
1c0f5c7
Compare
vankop
force-pushed
the
feat/concatenate-assets
branch
from
1c0f5c7
to
3ec8a60
Compare
sokra
requested changes
Mar 16, 2022
There was a problem hiding this comment.
NormalModule.codeGeneration still runs code generation for all source types, but it only has to run it for source types that remain in the chunk...
I'm also a bit worries about performance drawbacks that comes with these many accesses to sourceTypesByModule, but let's finish that up and measure afterwards...
vankop
force-pushed
the
feat/concatenate-assets
branch
from
da03829
to
1b7bd14
Compare
- in ConcatenatedModule generate only js - in NormalModule generate only used sources
vankop
force-pushed
the
feat/concatenate-assets
branch
from
1b7bd14
to
3f1715f
Compare
vankop
commented
Mar 28, 2022
vankop
force-pushed
the
feat/concatenate-assets
branch
from
f23ba1d
to
19d1a93
Compare
sokra
approved these changes
Apr 4, 2022
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
closes #13764
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing