New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resolving with yield #15423
Fix resolving with yield #15423
Conversation
…solve-issue-11335"" This reverts commit dd53923.
For maintainers only:
|
6544bbe
to
8d1e46e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add a test case where multiple results are yielded and the first one is empty and the second one successful.
e. g.
resolve: {
modules: ["a", "b"]
alias: {
[path.resolve(__dirname, "a/foo")]: false
}
}
const x = "x";
import(`foo/${x}`)
a/foo/x = "wrong"
and b/foo/x = "ok"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add a test case where multiple results are yielded and the first one is empty and the second one successful.
e. g.
resolve: {
modules: ["a", "b"]
alias: {
[path.resolve(__dirname, "a/foo")]: false
}
}
const x = "x";
import(`foo/${x}`)
a/foo/x = "wrong"
and b/foo/x = "ok"
8ebd760
to
10ebc91
Compare
10ebc91
to
e819c06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks |
What kind of change does this PR introduce?
fixes #15409
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing