Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude webpack-hot-middleware/client from lazy compilation #15202

Merged
merged 2 commits into from Jan 21, 2022

Conversation

tmeasday
Copy link
Contributor

@tmeasday tmeasday commented Jan 18, 2022

Lazy Compilation relies on the HMR mechanism so we need to ensure we don't lazy compile it. This hits a common use case, the HMR middleware, similar to prior exclusions for other HMR mechanisms.

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

I didn't see test for the other exclusions, but apologies if I missed these.

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 18, 2022

CLA Signed

The committers are authorized under a signed CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

@tmeasday Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@tmeasday
Copy link
Contributor Author

I just pushed the commit with a different email address :)

@sokra sokra merged commit f22a314 into webpack:main Jan 21, 2022
@sokra
Copy link
Member

sokra commented Jan 21, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants