Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding types #14855

Merged
merged 1 commit into from Dec 2, 2021
Merged

Adding types #14855

merged 1 commit into from Dec 2, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 29, 2021

@Brian-McBride rebase of #12875

What kind of change does this PR introduce?

This exposes more type definitions that are required for proper plugin development using Typescript.

Did you add tests for your changes?

There are no existing type tests. Added the types and ran the fix script as directed.

Does this PR introduce a breaking change?

Np, there are no type changes, just adding to the final export. The fix script changed the actual definition file. My edit was only to lib/index.js

What needs to be documented once your changes are merged?

Nothing. Typescript is self documentation.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra mentioned this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants