Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix names of options to match the exported types #14665

Merged
merged 1 commit into from Nov 8, 2021

Conversation

markjm
Copy link
Contributor

@markjm markjm commented Nov 6, 2021

The names of the new export options do not match the names present in the options schema. Note how different places have an "s" after exports while some don't. This change simply fixes all cases where the options used in webpack didn't match the outward display names.

reexportExportsPresence?: false | "error" | "warn" | "auto";

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
no, but fixes recently added tests

Does this PR introduce a breaking change?
kind of, but more fixes the options values introduced this morning

What needs to be documented once your changes are merged?
nothing beyond what needs to be documented for initial change

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@markjm
Copy link
Contributor Author

markjm commented Nov 6, 2021

@sokra this could have been caught if options schema disallowed additionalProperties on JavascriptParserOptions. Wondering if that is set as such for a reason, I guess if not, it is technically breaking change to fix that

@webpack-bot
Copy link
Contributor

@markjm The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from azure (0 errors / 5 warnings) and appveyor (failure) and fix these issues.

@sokra sokra merged commit 86e3eb2 into webpack:main Nov 8, 2021
@sokra
Copy link
Member

sokra commented Nov 8, 2021

Thanks

@markjm markjm deleted the markjm/option-names branch November 8, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants