Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace chunkIds[i] with chunkId in JsonpChunkLoadingRuntimeModule #14434

Merged
merged 2 commits into from Jan 10, 2022
Merged

replace chunkIds[i] with chunkId in JsonpChunkLoadingRuntimeModule #14434

merged 2 commits into from Jan 10, 2022

Conversation

buzuosheng
Copy link
Contributor

What kind of change does this PR introduce?
replace chunkIds[i] with chunkId in JsonpChunkLoadingRuntimeModule

Did you add tests for your changes?
no

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 8, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

@buzuosheng Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@webpack-bot
Copy link
Contributor

@buzuosheng The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from azure (1 errors / 1 warnings) and appveyor (failure) and fix these issues.

@alexander-akait
Copy link
Member

alexander-akait commented Dec 28, 2021 •
edited

Sorry for delay, can you update snapshots?

@buzuosheng
Copy link
Contributor Author

ok, i have done @alexander-akait

@alexander-akait
Copy link
Member

Thanks

@sokra sokra merged commit 98887e4 into webpack:main Jan 10, 2022
@sokra
Copy link
Member

sokra commented Jan 10, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: CI-not-ok PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@buzuosheng @webpack-bot @alexander-akait @sokra