Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Trusted Types in EvalSourceMapDevToolPlugin #14173

Merged
merged 11 commits into from Jan 20, 2022

Conversation

tosmolka
Copy link
Contributor

@tosmolka tosmolka commented Sep 8, 2021

This PR adds support for Trusted Types to eval devtool plugins, see #14075. Change should be backwards compatible and without perf impact when output.trustedTypes option is not set.

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

yes

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

I think current documentation is sufficient.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2021

CLA Signed

The committers are authorized under a signed CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@alexander-akait
Copy link
Member

Can you accept CLA?

@tosmolka
Copy link
Contributor Author

I am Corporate contributor, waiting on CLA Manager for Microsoft to review.

@alexander-akait
Copy link
Member

Feel free to ping me when it was ready

@tosmolka
Copy link
Contributor Author

Done. cc @alexander-akait

@tosmolka
Copy link
Contributor Author

Hello @alexander-akait , did you have a chance to review the PR, any feedback? Thanks. cc @sokra

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@tosmolka
Copy link
Contributor Author

Hello @alexander-akait , @sokra , I merged latest main in, can we get this reviewed pls? Let me know any concerns with the PR or the approach in general. Thank you.

@tosmolka
Copy link
Contributor Author

@alexander-akait , @sokra , friendly ping, can we get this reviewed pls? Do you have any concerns with the proposed implementation? Thanks.

cc @koto

@sokra sokra merged commit 1ed8aaf into webpack:main Jan 20, 2022
@sokra
Copy link
Member

sokra commented Jan 20, 2022

Thanks, sorry for the delay

@Jack-Works
Copy link
Contributor

Cool thanks, so it will be included in the next webpack release right?

@alexander-akait
Copy link
Member

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants