New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Trusted Types in EvalSourceMapDevToolPlugin #14173
Conversation
For maintainers only:
|
Can you accept CLA? |
I am Corporate contributor, waiting on CLA Manager for Microsoft to review. |
Feel free to ping me when it was ready |
Done. cc @alexander-akait |
Hello @alexander-akait , did you have a chance to review the PR, any feedback? Thanks. cc @sokra |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Hello @alexander-akait , @sokra , I merged latest main in, can we get this reviewed pls? Let me know any concerns with the PR or the approach in general. Thank you. |
@alexander-akait , @sokra , friendly ping, can we get this reviewed pls? Do you have any concerns with the proposed implementation? Thanks. cc @koto |
Thanks, sorry for the delay |
Cool thanks, so it will be included in the next webpack release right? |
Yes |
This PR adds support for Trusted Types to eval devtool plugins, see #14075. Change should be backwards compatible and without perf impact when output.trustedTypes option is not set.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
I think current documentation is sufficient.