Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match resource should not include special .webpack[...] extension #14134

Merged
merged 1 commit into from Sep 3, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 3, 2021

.webpack[] should not be used for resource path

What kind of change does this PR introduce?
fixes webpack-contrib/mini-css-extract-plugin#755

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

`.webpack[]` should not be used for resource path
@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit d056486 into main Sep 3, 2021
@sokra sokra deleted the bugfix/webpack-extension branch September 3, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loader rule issuer tests always fail when experimentalUseImportModule is enabled.
2 participants